Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for homebrew installation #167

Merged
merged 2 commits into from
Mar 24, 2019

Conversation

michaelwoods
Copy link
Contributor

@michaelwoods michaelwoods commented Feb 11, 2019

The PR for adding this as a formula in homebrew is not yet reviewed nor merged, so I would suggest holding off on this PR until that is complete (it's my first homebrew submission, so I may need to make updates there).

For homebrew users (ie OSX only) all that would be required to install is:
brew install hass-cli

Further updates would be automatic for end users via the usual brew upgrade process. New hass-cli releases require updates to the formula.

Request issue: #146
Formula PR: Homebrew/homebrew-core#36915

@homeassistant
Copy link

Hi @michaelwoods,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@maxandersen
Copy link
Contributor

Thanks @michaelwoods !

I'll keep an eye on the brew PR.

One thing though - just to be consistent across pip, docker and now brew I would prefer they all use the same "name", i.e. homeassistant-cli rather than just hass-cli.

Looking at the PR if I grok it right we would somehow need to update that formula on every release ? That seems supertedious to nag the brew PR on every release....wonder how fast they'll process them.

@michaelwoods
Copy link
Contributor Author

That's right, the homebrew repo needs a PR for every update. I'd be willing to maintain that myself, if even for major updates only if things move quickly.

I'm certainly open to changing the name of the formula, but I wonder why the command is named hass-cli if that's the case? Looking through my list of brew list installed formula, they're mostly all the name of the actual command used. I'm pretty sure I can use name homeassistant-cli while linking the executable hass-cli.

@maxandersen
Copy link
Contributor

I wonder why the command is named hass-cli if that's the case

Its named hass-cli because the command in homeassistant itself is called hass.

@michaelwoods
Copy link
Contributor Author

@maxandersen the formula was merged, you can include this documentation update if you'd like.

@fabaff fabaff merged commit 0a3e30b into home-assistant-ecosystem:dev Mar 24, 2019
@michaelwoods michaelwoods deleted the patch-1 branch April 4, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants